Turned on all the warnings I could handle and made them into errors then fixed them all. Worldbuilder needs a refactor in random_path.

tests/ansi_parser.cpp

@@ -66,8 +66,7 @@ TEST_CASE("test out ragel parser", "[gui]") {
   std::wstring colors_utf = $converter.from_bytes(colors);
 
   bool good = ansi.parse(colors_utf,
-      [&](sf::Color color, sf::Color bgcolor){
-        // ignore color
+      [&](sf::Color color[[maybe_unused]], sf::Color bgcolor[[maybe_unused]]){
       },
       [&](wchar_t ch) {
       bool correct_char = ch == '#' || ch == ' ' || ch == '\n' || ch == '\r';

tests/dinkyecs.cpp

@@ -119,8 +119,14 @@ TEST_CASE("confirm ECS system works", "[ecs]") {
 
   println("--- After remove test, should only result in test2:");
   world.query<Position, Velocity>([&](const auto &ent, auto &pos, auto &vel) {
+      auto &in_position = world.get<Position>(ent);
+      auto &in_velocity = world.get<Velocity>(ent);
       REQUIRE(pos.x >= 0);
       REQUIRE(pos.y >= 0);
+      REQUIRE(in_position.x == pos.x);
+      REQUIRE(in_position.y == pos.y);
+      REQUIRE(in_velocity.x == vel.x);
+      REQUIRE(in_velocity.y == vel.y);
   });
 }
 

tests/fsm.cpp

@@ -25,7 +25,7 @@ public:
   }
 
   void START(MyEvent ev) {
-    println("<<< START");
+    println("<<< START {}", (int)ev);
     state(MyState::RUNNING);
   }
 
@@ -40,7 +40,7 @@ public:
   }
 
   void END(MyEvent ev) {
-    println("<<< STOP");
+    println("<<< STOP {}", (int)ev);
     state(MyState::END);
   }
 };

tests/panel.cpp

@@ -17,10 +17,10 @@ void test_ansi_parsing(Panel &panel) {
   ANSIParser ansi(default_fg, default_bg);
 
   bool good = ansi.parse(panel.to_string(),
-    [&](sf::Color color, sf::Color bgcolor){
+    [&](sf::Color color[[maybe_unused]], sf::Color bgcolor[[maybe_unused]]){
       // ignore color
     },
-    [&](wchar_t ch) {
+    [&](wchar_t ch[[maybe_unused]]) {
       // ignore char
   });